]> git.baikalelectronics.ru Git - kernel.git/commit
floppy: cleanup: add a few comments about expectations in certain functions
authorWilly Tarreau <w@1wt.eu>
Tue, 31 Mar 2020 09:40:54 +0000 (11:40 +0200)
committerDenis Efremov <efremov@linux.com>
Tue, 12 May 2020 16:34:55 +0000 (19:34 +0300)
commit40a1862fe7828ba85a76beb1027f0562c0a784cb
tree8b949858f8ddb4549c2efc89be02fb32ba8b5210
parentbf1959b6f00db1cb9f7911036b43ed33e900ccbb
floppy: cleanup: add a few comments about expectations in certain functions

The locking in the driver is far from being obvious, with unlocking
automatically happening at end of operations scheduled by interrupt,
especially for the error paths where one does not necessarily expect
that such an interrupt may be triggered. Let's add a few comments
about what to expect at certain places to avoid misdetecting bugs
which are not.

Link: https://lore.kernel.org/r/20200331094054.24441-24-w@1wt.eu
Signed-off-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Denis Efremov <efremov@linux.com>
drivers/block/floppy.c