]> git.baikalelectronics.ru Git - kernel.git/commit
drm/nouveau/kms/nv50: perform null check on msto[i] rathern than msto
authorColin Ian King <colin.king@canonical.com>
Thu, 17 Aug 2017 22:03:23 +0000 (23:03 +0100)
committerBen Skeggs <bskeggs@redhat.com>
Tue, 22 Aug 2017 08:04:36 +0000 (18:04 +1000)
commit408752e5aebafd98192b8c021defff7e37c3498a
tree7f1e9e8fc879d1013136b7b88fa609bd4f6da065
parentfb93dcd7fdac74288e13b07c86a7f81005357c44
drm/nouveau/kms/nv50: perform null check on msto[i] rathern than msto

The null check on the array msto is incorrect since msto is never
null. The null check should be instead on msto[i] since this is
being dereferenced in the call to drm_mode_connector_attach_encoder.

Thanks to Emil Velikov for pointing out the mistake in my original
fix and for suggesting the correct fix.

Detected by CoverityScan, CID#1375915 ("Array compared against 0")

Fixes: 9b445939f797 ("drm/nouveau/kms/nv50: initial support for DP 1.2 multi-stream")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
drivers/gpu/drm/nouveau/nv50_display.c