]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915/vbt: don't propagate errors from intel_bios_init()
authorJani Nikula <jani.nikula@intel.com>
Fri, 10 Mar 2017 13:27:57 +0000 (15:27 +0200)
committerJani Nikula <jani.nikula@intel.com>
Mon, 13 Mar 2017 09:52:07 +0000 (11:52 +0200)
commit3ff9f6c07b81675426a841fd85615007737c5b72
treee6f6bcc86c5f3d59331e7165d6ea21ba98f451bf
parent34709d111b3eb16cd26d9d782816672687afb90e
drm/i915/vbt: don't propagate errors from intel_bios_init()

We don't use the error return for anything other than reporting and
logging that there is no VBT. We can pull the logging in the function,
and remove the error status return. Moreover, if we needed the
information for something later on, we'd probably be better off storing
the bit in dev_priv, and using it where it's needed, instead of using
the error return.

While at it, improve the comments.

Cc: Manasi Navare <manasi.d.navare@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/438ebbb0d5f0d321c625065b9cc78532a1dab24f.1489152288.git.jani.nikula@intel.com
drivers/gpu/drm/i915/i915_drv.c
drivers/gpu/drm/i915/i915_drv.h
drivers/gpu/drm/i915/intel_bios.c