]> git.baikalelectronics.ru Git - kernel.git/commit
bcm63xx_enet: fix sporadic kernel panic
authorSieng Piaw Liew <liew.s.piaw@gmail.com>
Mon, 22 Feb 2021 01:35:30 +0000 (09:35 +0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 23 Feb 2021 20:15:04 +0000 (12:15 -0800)
commit3ef5fac594a3393d617f01b34cc3f1184c13e071
treea6e241c8776976b8fe48dd628cc7d43711523ba7
parentf190038defc399a0b9cec7ad422ef3b574ad59e7
bcm63xx_enet: fix sporadic kernel panic

In ndo_stop functions, netdev_completed_queue() is called during forced
tx reclaim, after netdev_reset_queue(). This may trigger kernel panic if
there is any tx skb left.

This patch moves netdev_reset_queue() to after tx reclaim, so BQL can
complete successfully then reset.

Signed-off-by: Sieng Piaw Liew <liew.s.piaw@gmail.com>
Fixes: bf0bb49faf67 ("bcm63xx_enet: add BQL support")
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20210222013530.1356-1-liew.s.piaw@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/bcm63xx_enet.c