]> git.baikalelectronics.ru Git - kernel.git/commit
spi: spidev_test: Use perror() only if errno is not 0
authorTiezhu Yang <yangtiezhu@loongson.cn>
Thu, 13 Feb 2020 04:16:07 +0000 (12:16 +0800)
committerMark Brown <broonie@kernel.org>
Thu, 13 Feb 2020 13:17:39 +0000 (13:17 +0000)
commit3ed19a9930bdd4c89de08ba60bbe9c61dc598155
treefdf990e9665f3f1dbc29fcf73140ad8b5b08e0ed
parente497ba397b1e8026ab2ea0173331c3f6708a2364
spi: spidev_test: Use perror() only if errno is not 0

It is better to use perror() only if errno is not 0, it should use printf()
when errno is 0, otherwise there exists redudant ": Success".

E.g. without this patch:

$ ./spidev_test -p 1234 --input test.bin
only one of -p and --input may be selected: Success
Aborted (core dumped)

With this patch:

$ ./spidev_test -p 1234 --input test.bin
only one of -p and --input may be selected
Aborted (core dumped)

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/1581567368-8055-3-git-send-email-yangtiezhu@loongson.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
tools/spi/spidev_test.c