]> git.baikalelectronics.ru Git - kernel.git/commit
blk-mq: don't touch ->tagset in blk_mq_get_sq_hctx
authorMing Lei <ming.lei@redhat.com>
Sun, 22 May 2022 12:23:50 +0000 (20:23 +0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 23 May 2022 12:28:28 +0000 (06:28 -0600)
commit3ec470932cedf9da17b57b41f2b1baab13ef379e
tree1d606e3f04b70a0c8a96c4e3bb6f43bb2e6473a9
parent70a57ade4b31e004c92147f7b3fcb9ffad651ac1
blk-mq: don't touch ->tagset in blk_mq_get_sq_hctx

blk_mq_run_hw_queues() could be run when there isn't queued request and
after queue is cleaned up, at that time tagset is freed, because tagset
lifetime is covered by driver, and often freed after blk_cleanup_queue()
returns.

So don't touch ->tagset for figuring out current default hctx by the mapping
built in request queue, so use-after-free on tagset can be avoided. Meantime
this way should be fast than retrieving mapping from tagset.

Cc: "yukuai (C)" <yukuai3@huawei.com>
Cc: Jan Kara <jack@suse.cz>
Fixes: 10c6e80aed4f ("blk-mq: Improve performance of non-mq IO schedulers with multiple HW queues")
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20220522122350.743103-1-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq.c