]> git.baikalelectronics.ru Git - kernel.git/commit
Drivers: hv: Always reserve framebuffer region for Gen1 VMs
authorVitaly Kuznetsov <vkuznets@redhat.com>
Sat, 27 Aug 2022 13:03:44 +0000 (15:03 +0200)
committerWei Liu <wei.liu@kernel.org>
Mon, 5 Sep 2022 17:02:15 +0000 (17:02 +0000)
commit3e52addfb6d68252424c9579af7a607c49f993d1
treeac9ebdf010e5695bf87197264517b268e0f17fc9
parent54748fb0ecb67c996f8db097ffef89ee893d3ca8
Drivers: hv: Always reserve framebuffer region for Gen1 VMs

vmbus_reserve_fb() tries reserving framebuffer region iff
'screen_info.lfb_base' is set. Gen2 VMs seem to have it set by EFI
and/or by the kernel EFI FB driver (or, in some edge cases like kexec,
the address where the buffer was moved, see
https://lore.kernel.org/all/20201014092429.1415040-1-kasong@redhat.com/)
but on Gen1 VM it depends on bootloader behavior. With grub, it depends
on 'gfxpayload=' setting but in some cases it is observed to be zero.
That being said, relying on 'screen_info.lfb_base' to reserve
framebuffer region is risky. For Gen1 VMs, it should always be
possible to get the address from the dedicated PCI device instead.

Check for legacy PCI video device presence and reserve the whole
region for framebuffer on Gen1 VMs.

Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Link: https://lore.kernel.org/r/20220827130345.1320254-3-vkuznets@redhat.com
Signed-off-by: Wei Liu <wei.liu@kernel.org>
drivers/hv/vmbus_drv.c