]> git.baikalelectronics.ru Git - kernel.git/commit
sg_start_req(): make sure that there's not too many elements in iovec
authorAl Viro <viro@zeniv.linux.org.uk>
Sun, 22 Mar 2015 00:08:18 +0000 (20:08 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Sun, 12 Apr 2015 02:27:13 +0000 (22:27 -0400)
commit3e4bdd906d013f7fbc3646950f7b4be92ff6d04b
tree33dbcccb975a1943c7f015e54f0ce148f2bbc3d5
parent214007dfb5ddfaa5b7e61087f2b88ff429c79b6a
sg_start_req(): make sure that there's not too many elements in iovec

unfortunately, allowing an arbitrary 16bit value means a possibility of
overflow in the calculation of total number of pages in bio_map_user_iov() -
we rely on there being no more than PAGE_SIZE members of sum in the
first loop there.  If that sum wraps around, we end up allocating
too small array of pointers to pages and it's easy to overflow it in
the second loop.

X-Coverup: TINC (and there's no lumber cartel either)
Cc: stable@vger.kernel.org # way, way back
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
drivers/scsi/sg.c