]> git.baikalelectronics.ru Git - kernel.git/commit
i2c: i801: Ensure that SMBHSTSTS_INUSE_STS is cleared when leaving i801_access
authorHeiner Kallweit <hkallweit1@gmail.com>
Sun, 6 Jun 2021 13:55:55 +0000 (15:55 +0200)
committerWolfram Sang <wsa@kernel.org>
Sun, 20 Jun 2021 20:58:58 +0000 (22:58 +0200)
commit3deb141497ebdbce9cd030f8461bf913d98f192a
treef02f40e128b5dafd8df9b6a885e84bc9ad31009b
parentfe8b090db1728e313ba3d15b89c5676907859a29
i2c: i801: Ensure that SMBHSTSTS_INUSE_STS is cleared when leaving i801_access

As explained in [0] currently we may leave SMBHSTSTS_INUSE_STS set,
thus potentially breaking ACPI/BIOS usage of the SMBUS device.

Seems patch [0] needs a little bit more of review effort, therefore
I'd suggest to apply a part of it as quick win. Just clearing
SMBHSTSTS_INUSE_STS when leaving i801_access() should fix the
referenced issue and leaves more time for discussing a more
sophisticated locking handling.

[0] https://www.spinics.net/lists/linux-i2c/msg51558.html

Fixes: 28f00a0e5999 ("i2c: i801: Instantiate SPD EEPROMs automatically")
Suggested-by: Hector Martin <marcan@marcan.st>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Hector Martin <marcan@marcan.st>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Tested-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-i801.c