]> git.baikalelectronics.ru Git - kernel.git/commit
vfs: read file_handle only once in handle_to_path
authorSasha Levin <sasha.levin@oracle.com>
Wed, 28 Jan 2015 20:30:43 +0000 (15:30 -0500)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 2 Jun 2015 17:29:07 +0000 (10:29 -0700)
commit3d66432f6768bb01a178ee499f8777f78adcdd8d
tree03b54e12af45ca97641f8d86113c67b5a929b006
parente1c24d868ef0dec4c1d173dd1f3bc0f690cdde82
vfs: read file_handle only once in handle_to_path

We used to read file_handle twice.  Once to get the amount of extra
bytes, and once to fetch the entire structure.

This may be problematic since we do size verifications only after the
first read, so if the number of extra bytes changes in userspace between
the first and second calls, we'll have an incoherent view of
file_handle.

Instead, read the constant size once, and copy that over to the final
structure without having to re-read it again.

Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: stable@vger.kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/fhandle.c