]> git.baikalelectronics.ru Git - kernel.git/commit
net: mvpp2: debugfs: fix memory leak when using debugfs_lookup()
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 2 Sep 2022 13:41:11 +0000 (15:41 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 5 Sep 2022 13:18:32 +0000 (14:18 +0100)
commit3ce48957b1db2ec8d8385878f70f88c3461712d1
treef74b3d865a5eba4e2c9b2a8bae7bade97e0b7f95
parentcdca66f3824f2e54d2ee258c9893c9bbeef9e706
net: mvpp2: debugfs: fix memory leak when using debugfs_lookup()

When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time.  Fix this up to be much
simpler logic and only create the root debugfs directory once when the
driver is first accessed.  That resolves the memory leak and makes
things more obvious as to what the intent is.

Cc: Marcin Wojtas <mw@semihalf.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org
Cc: stable <stable@kernel.org>
Fixes: 39d7629f2ab8 ("net: mvpp2: add a debugfs interface for the Header Parser")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c