]> git.baikalelectronics.ru Git - kernel.git/commit
net: dsa: Avoid null pointer when failing to connect to PHY
authorVladimir Oltean <olteanv@gmail.com>
Sat, 23 Mar 2019 23:24:07 +0000 (01:24 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 26 Mar 2019 18:26:55 +0000 (11:26 -0700)
commit3c4509aa1df6e7998e89a22e45f32ffab46434e8
treefc04d26f6cc2f095c3fccfa781931a8920fb0eb6
parent03339083d443fad31c5c1aa5defe5ac82c601ab4
net: dsa: Avoid null pointer when failing to connect to PHY

When phylink_of_phy_connect fails, dsa_slave_phy_setup tries to save the
day by connecting to an alternative PHY, none other than a PHY on the
switch's internal MDIO bus, at an address equal to the port's index.

However this does not take into consideration the scenario when the
switch that failed to probe an external PHY does not have an internal
MDIO bus at all.

Fixes: ec15f293ff9e ("net: dsa: Plug in PHYLINK support")
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dsa/slave.c