]> git.baikalelectronics.ru Git - kernel.git/commit
usb: gadget: lpc32xx_udc: don't dereference ep pointer before null check
authorColin Ian King <colin.king@canonical.com>
Thu, 21 May 2020 15:13:00 +0000 (16:13 +0100)
committerFelipe Balbi <balbi@kernel.org>
Mon, 25 May 2020 08:09:43 +0000 (11:09 +0300)
commit3c443d36e3c3232b0ea70bd0bbfa9837556da849
tree131361025f4b9c2eda5024e461bb5fc8e8b3439d
parentd3ab41410a04e8dbf3c8edd4b14e45d674cb91aa
usb: gadget: lpc32xx_udc: don't dereference ep pointer before null check

Currently pointer ep is being dereferenced before it is null checked
leading to a null pointer dereference issue.  Fix this by only assigning
pointer udc once ep is known to be not null.  Also remove a debug
message that requires a valid udc which may not be possible at that
point.

Addresses-Coverity: ("Dereference before null check")
Fixes: ba198f21b866 ("USB: gadget driver for LPC32xx")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
drivers/usb/gadget/udc/lpc32xx_udc.c