]> git.baikalelectronics.ru Git - kernel.git/commit
net: ethernet: mvneta: fix MVNETA_SKB_HEADROOM alignment
authorAlexander Lobakin <bloodyreaper@yandex.ru>
Fri, 5 Jun 2020 12:53:24 +0000 (15:53 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 5 Jun 2020 20:13:11 +0000 (13:13 -0700)
commit3c1ce2f34f8b3e781b1ec27912b9daeabcda9fba
tree79a723b982279361a2b9eafee5827ff9fc9ff951
parentefbb58203ca51f6e06aa1b2f48faf5b52779392e
net: ethernet: mvneta: fix MVNETA_SKB_HEADROOM alignment

Commit 6a446b0435f3 ("mvneta: MVNETA_SKB_HEADROOM set last 3 bits to zero")
added headroom alignment check against 8.
Hovewer (if we imagine that NET_SKB_PAD or XDP_PACKET_HEADROOM is not
aligned to cacheline size), it actually aligns headroom down, while
skb/xdp_buff headroom should be *at least* equal to one of the values
(depending on XDP prog presence).
So, fix the check to align the value up. This satisfies both
hardware/driver and network stack requirements.

Fixes: 6a446b0435f3 ("mvneta: MVNETA_SKB_HEADROOM set last 3 bits to zero")
Signed-off-by: Alexander Lobakin <bloodyreaper@yandex.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/mvneta.c