]> git.baikalelectronics.ru Git - kernel.git/commit
printk: remove unneeded dead-store assignment
authorLukas Bulwahn <lukas.bulwahn@gmail.com>
Fri, 6 Nov 2020 03:40:05 +0000 (04:40 +0100)
committerPetr Mladek <pmladek@suse.com>
Fri, 6 Nov 2020 10:05:44 +0000 (11:05 +0100)
commit3c1b6f4304fd4a168ae8d6ae35d60bec85c1bd72
treeca51be9bfe2d4790c1ae54778b9cccba2a1f1c7f
parent6ca4a70dbf721e2cd24fdf5c42db81390cc776b7
printk: remove unneeded dead-store assignment

make clang-analyzer on x86_64 defconfig caught my attention with:

  kernel/printk/printk_ringbuffer.c:885:3: warning:
  Value stored to 'desc' is never read [clang-analyzer-deadcode.DeadStores]

desc = to_desc(desc_ring, head_id);
^

Commit dcb10411cf26 ("printk: add lockless ringbuffer") introduced
desc_reserve() with this unneeded dead-store assignment.

As discussed with John Ogness privately, this is probably just some minor
left-over from previous iterations of the ringbuffer implementation. So,
simply remove this unneeded dead assignment to make clang-analyzer happy.

As compilers will detect this unneeded assignment and optimize this anyway,
the resulting object code is identical before and after this change.

No functional change. No change to object code.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20201106034005.18822-1-lukas.bulwahn@gmail.com
kernel/printk/printk_ringbuffer.c