]> git.baikalelectronics.ru Git - kernel.git/commit
ufs: Fix possible deadlock when looking up directories
authorJan Kara <jack@suse.cz>
Tue, 2 Jun 2015 09:26:34 +0000 (11:26 +0200)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 16 Jun 2015 06:08:12 +0000 (02:08 -0400)
commit3c11d97a7b958ffa9260bbf810c8f239997310e2
tree62b4f0f249c523eaba9fe4b8ce407782922a5b11
parente744e24c7baad7c778bdbb1eda1d956ee60e4167
ufs: Fix possible deadlock when looking up directories

Commit 7af257db9ebf09641 (ufs: deal with nfsd/iget races) made ufs
create inodes with I_NEW flag set. However ufs_mkdir() never cleared
this flag. Thus if someone ever tried to lookup the directory by inode
number, he would deadlock waiting for I_NEW to be cleared. Luckily this
mostly happens only if the filesystem is exported over NFS since
otherwise we have the inode attached to dentry and don't look it up by
inode number. In rare cases dentry can get freed without inode being
freed and then we'd hit the deadlock even without NFS export.

Fix the problem by clearing I_NEW before instantiating new directory
inode.

Fixes: 7af257db9ebf0964127937a0a068c5eb098ded73
Reported-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/ufs/namei.c