]> git.baikalelectronics.ru Git - kernel.git/commit
b43legacy: fix unitialized reads of ret by initializing the array to zero
authorColin Ian King <colin.king@canonical.com>
Tue, 5 Sep 2017 18:16:58 +0000 (19:16 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 20 Sep 2017 12:41:08 +0000 (15:41 +0300)
commit3c008b721bceffbbbc029304c0246052fccb82d8
treee584d8e03064145775d471ee029737bd2e937e1a
parent15c33fc6bf4730e32c4b4d983fc8990cab9a5c19
b43legacy: fix unitialized reads of ret by initializing the array to zero

The u8 char array ret is not being initialized and elements outside
the range start to end contain just garbage values from the stack.
This results in a later scan of the array to read potentially
uninitialized values.  Fix this by initializing the array to zero.
This seems to have been an issue since the very first commit.

Detected by CoverityScan CID#139653 ("Uninitialized scalar variable")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Michael Buesch <m@bues.ch>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/b43legacy/radio.c