]> git.baikalelectronics.ru Git - kernel.git/commit
PCI: pciehp: Drop unnecessary NULL pointer check
authorLukas Wunner <lukas@wunner.de>
Thu, 19 Jul 2018 22:27:35 +0000 (17:27 -0500)
committerBjorn Helgaas <helgaas@kernel.org>
Mon, 23 Jul 2018 22:04:11 +0000 (17:04 -0500)
commit3ba01ac74b9765b574d6b6693520f21b950608da
treee27984838abbdba625e7e0342ab16884c1ebb404
parent68e53e2f89846af24f69839f90acc6e3c5d50867
PCI: pciehp: Drop unnecessary NULL pointer check

pciehp_disable_slot() checks if the ctrl attribute of the slot is NULL
and bails out if so.  However the function is not called prior to the
attribute being set in pcie_init_slot(), and pcie_init_slot() is not
called if ctrl is NULL.  So the check is unnecessary.  Drop it.

It has been present ever since the driver was introduced in 2004, but it
was already unnecessary back then:
https://git.kernel.org/tglx/history/c/c16b4b14d980

Signed-off-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/hotplug/pciehp_ctrl.c