]> git.baikalelectronics.ru Git - kernel.git/commit
nfp: fix potential use after free on xdp prog
authorJakub Kicinski <jakub.kicinski@netronome.com>
Tue, 4 Apr 2017 22:56:55 +0000 (15:56 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 6 Apr 2017 01:46:40 +0000 (18:46 -0700)
commit3b7bbcd0eb91007e69204f4733657430aa1def4d
treef46a23718a949591f4161dadc902368452d7858f
parentc37641deaa59a575824c023dc5f8eae111fefbed
nfp: fix potential use after free on xdp prog

We should unregister the net_device first, before we give back
our reference on xdp_prog.  Otherwise xdp_prog may be freed
before .ndo_stop() disabled the datapath.  Found by code inspection.

Fixes: 799811507b23 ("nfp: add XDP support in the driver")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/netronome/nfp/nfp_net_common.c