]> git.baikalelectronics.ru Git - kernel.git/commit
can: netlink: allow configuring of fixed bit rates without need for do_set_bittiming...
authorMarc Kleine-Budde <mkl@pengutronix.de>
Sat, 11 Jun 2022 14:20:58 +0000 (16:20 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Sat, 11 Jun 2022 15:08:17 +0000 (17:08 +0200)
commit3b204db75b63618b913e67acdacb7c0c49b43379
tree3695a16772bbb30487d89c169e5a38928b5cee4d
parent9d8b7eb1325548912064103442ee22a7f76d4f0c
can: netlink: allow configuring of fixed bit rates without need for do_set_bittiming callback

Usually CAN devices support configurable bit rates. The limits are
defined by struct can_priv::bittiming_const. Another way is to
implement the struct can_priv::do_set_bittiming callback.

If the bit rate is configured via netlink, the can_changelink()
function checks that either can_priv::bittiming_const or struct
can_priv::do_set_bittiming is implemented.

In commit 405abb0e0c7b ("can: dev: add CAN interface API for fixed
bitrates") an API for configuring bit rates on CAN interfaces that
only support fixed bit rates was added. The supported bit rates are
defined by struct can_priv::bitrate_const.

However the above mentioned commit forgot to add the struct
can_priv::bitrate_const to the check in can_changelink().

In order to avoid to implement a no-op can_priv::do_set_bittiming
callback on devices with fixed bit rates, extend the check in
can_changelink() accordingly.

Link: https://lore.kernel.org/all/20220611144248.3924903-1-mkl@pengutronix.de
Fixes: 405abb0e0c7b ("can: dev: add CAN interface API for fixed bitrates")
Reported-by: Max Staudt <max@enpas.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/dev/netlink.c