]> git.baikalelectronics.ru Git - kernel.git/commit
net: dsa: tag_8021q: Future-proof the reserved fields in the custom VID
authorVladimir Oltean <olteanv@gmail.com>
Sun, 25 Aug 2019 18:32:12 +0000 (21:32 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 28 Aug 2019 03:31:12 +0000 (20:31 -0700)
commit3af7a571a9ad42567ae002927b51a9fe117d4217
treece18c6dc616360102275569798204bf33144ab8b
parentb886895a1c413b40a7d81758153aacff3322649f
net: dsa: tag_8021q: Future-proof the reserved fields in the custom VID

After witnessing the discussion in https://lkml.org/lkml/2019/8/14/151
w.r.t. ioctl extensibility, it became clear that such an issue might
prevent that the 3 RSV bits inside the DSA 802.1Q tag might also suffer
the same fate and be useless for further extension.

So clearly specify that the reserved bits should currently be
transmitted as zero and ignored on receive. The DSA tagger already does
this (and has always did), and is the only known user so far (no
Wireshark dissection plugin, etc). So there should be no incompatibility
to speak of.

Fixes: ff76df78a2db ("net: dsa: tag_8021q: Create a stable binary format")
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dsa/tag_8021q.c