]> git.baikalelectronics.ru Git - kernel.git/commit
rtc: check if __rtc_read_time was successful
authorTom Rix <trix@redhat.com>
Sat, 26 Mar 2022 19:42:36 +0000 (12:42 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 12:24:10 +0000 (14:24 +0200)
commit39f1f3fa388816090b2b7d8899fcf5112f43a948
tree3b082e26a413279ea28f69c75cf11c4b93e1e4fb
parent088565211a3d8242d569c06518908e4f7b97e530
rtc: check if __rtc_read_time was successful

commit 9b59661611f7d08bb7dbaa64d2f4052a3368210e upstream.

Clang static analysis reports this issue
interface.c:810:8: warning: Passed-by-value struct
  argument contains uninitialized data
  now = rtc_tm_to_ktime(tm);
      ^~~~~~~~~~~~~~~~~~~

tm is set by a successful call to __rtc_read_time()
but its return status is not checked.  Check if
it was successful before setting the enabled flag.
Move the decl of err to function scope.

Fixes: fed8a941785a ("rtc: interface: ignore expired timers when enqueuing new timers")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20220326194236.2916310-1-trix@redhat.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/rtc/interface.c