]> git.baikalelectronics.ru Git - kernel.git/commit
gpiolib: of: fix a memory leak in of_gpio_flags_quirks()
authorNishka Dasgupta <nishkadg.linux@gmail.com>
Sat, 6 Jul 2019 13:34:22 +0000 (19:04 +0530)
committerBartosz Golaszewski <bgolaszewski@baylibre.com>
Mon, 15 Jul 2019 09:52:34 +0000 (11:52 +0200)
commit39e04d7a6835048b3ade468f5954502bc2cf4680
treeed89009e2db5828ffef793ecabb9b11af9ce5493
parente09b36e0bb247b26d49884776f5c5eed1a1c5990
gpiolib: of: fix a memory leak in of_gpio_flags_quirks()

Each iteration of for_each_child_of_node puts the previous node, but in
the case of a break from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the break.
Issue found with Coccinelle.

Cc: <stable@vger.kernel.org>
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
[Bartosz: tweaked the commit message]
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
drivers/gpio/gpiolib-of.c