]> git.baikalelectronics.ru Git - kernel.git/commit
net: phy: fix MDIO bus PM PHY resuming
authorHeiner Kallweit <hkallweit1@gmail.com>
Thu, 12 Mar 2020 21:25:20 +0000 (22:25 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 12 Mar 2020 22:36:12 +0000 (15:36 -0700)
commit39dfe53dfd51fdfbda72cb7fb6fc20615617d91f
tree382177a2a8158add5d4d5950044888912b07a32b
parent36d000070be0fc82d5962c9b81f2cb65cd7f7c8f
net: phy: fix MDIO bus PM PHY resuming

So far we have the unfortunate situation that mdio_bus_phy_may_suspend()
is called in suspend AND resume path, assuming that function result is
the same. After the original change this is no longer the case,
resulting in broken resume as reported by Geert.

To fix this call mdio_bus_phy_may_suspend() in the suspend path only,
and let the phy_device store the info whether it was suspended by
MDIO bus PM.

Fixes: d8ae1ca1943a ("net: phy: Avoid multiple suspends")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Tested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phy_device.c
include/linux/phy.h