]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Don't oops in dumb_create ioctl if we have no crtcs
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 6 Nov 2019 17:23:49 +0000 (19:23 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 8 Nov 2019 13:43:21 +0000 (15:43 +0200)
commit39cd836324db48d00f958586935e88d3d13b3932
tree12833d927a532a2e0875cd7dd180d618507ea555
parentfad4c370f56ace73695cdd6c6e04c580a8a960f7
drm/i915: Don't oops in dumb_create ioctl if we have no crtcs

Make sure we have a crtc before probing its primary plane's
max stride. Initially I thought we can't get this far without
crtcs, but looks like we can via the dumb_create ioctl.

Not sure if we shouldn't disable dumb buffer support entirely
when we have no crtcs, but that would require some amount of work
as the only thing currently being checked is dev->driver->dumb_create
which we'd have to convert to some device specific dynamic thing.

Cc: stable@vger.kernel.org
Reported-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Fixes: 3d86a6cd8a84 ("drm/i915: Align dumb buffer stride to 4k to allow for gtt remapping")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191106172349.11987-1-ville.syrjala@linux.intel.com
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
drivers/gpu/drm/i915/display/intel_display.c