]> git.baikalelectronics.ru Git - kernel.git/commit
net: stmmac: fix order of dwmac5 FlexPPS parametrization sequence
authorJohannes Zink <j.zink@pengutronix.de>
Fri, 10 Feb 2023 14:39:37 +0000 (15:39 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Feb 2023 11:59:52 +0000 (12:59 +0100)
commit39be90211839506ee3fda7075392f225f975919a
tree0abc13147d0ea29dd54fe7df682f53b8415151f5
parente3af79532ad7e58c8e10ee66e0178802ddd4dec8
net: stmmac: fix order of dwmac5 FlexPPS parametrization sequence

commit f4036298d7934bb1d0bf91ba9f5e505cdfedcfac upstream.

So far changing the period by just setting new period values while
running did not work.

The order as indicated by the publicly available reference manual of the i.MX8MP [1]
indicates a sequence:

 * initiate the programming sequence
 * set the values for PPS period and start time
 * start the pulse train generation.

This is currently not used in dwmac5_flex_pps_config(), which instead does:

 * initiate the programming sequence and immediately start the pulse train generation
 * set the values for PPS period and start time

This caused the period values written not to take effect until the FlexPPS output was
disabled and re-enabled again.

This patch fix the order and allows the period to be set immediately.

[1] https://www.nxp.com/webapp/Download?colCode=IMX8MPRM

Fixes: 14776e3b568c ("net: stmmac: Add Flexible PPS support")
Signed-off-by: Johannes Zink <j.zink@pengutronix.de>
Link: https://lore.kernel.org/r/20230210143937.3427483-1-j.zink@pengutronix.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/stmicro/stmmac/dwmac5.c