]> git.baikalelectronics.ru Git - kernel.git/commit
md/raid5: Assigning NULL to sh->batch_head before testing bit R5_Overlap of a stripe
authorAmy Chiang <amychiang@qnap.com>
Wed, 16 May 2018 10:59:35 +0000 (18:59 +0800)
committerShaohua Li <shli@fb.com>
Thu, 17 May 2018 16:56:00 +0000 (09:56 -0700)
commit393321b6f6853030a2deec924fdf9e277cadec20
tree93f2a31884891c877ea6fd7e4d4cdcd70119490a
parent77f0667f9ac9211fe8638cd5e5d56b18f529b1f3
md/raid5: Assigning NULL to sh->batch_head before testing bit R5_Overlap of a stripe

In add_stripe_bio(), if the stripe_head is in batch list, the incoming
bio is regarded as overlapping, and the bit R5_Overlap on this stripe_head
is set. break_stripe_batch_list() checks bit R5_Overlap on each stripe_head
first then assigns NULL to sh->batch_head.

If break_stripe_batch_list() checks bit R5_Overlap on stripe_head A
after add_stripe_bio() finds stripe_head A is in batch list and before
add_stripe_bio() sets bit R5_Overlapt of stripe_head A,
break_stripe_batch_list() would not know there's a process in
wait_for_overlap and needs to call wake_up(). There's a huge chance a
process never returns from schedule() if add_stripe_bio() is called
from raid5_make_request().

In break_stripe_batch_list(), assigning NULL to sh->batch_head should
be done before it checks bit R5_Overlap of a stripe_head.

Signed-off-by: Amy Chiang <amychiang@qnap.com>
Signed-off-by: Shaohua Li <shli@fb.com>
drivers/md/raid5.c