]> git.baikalelectronics.ru Git - kernel.git/commit
Input: ps2-gpio - enforce GPIOs flag open drain
authorDanilo Krummrich <danilokrummrich@dk-develop.de>
Tue, 15 Feb 2022 22:55:44 +0000 (14:55 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 16 Feb 2022 01:25:41 +0000 (17:25 -0800)
commit3902687b429cf74c625d11523ee6bfafd3f2d95e
tree1269e5854c05876f07e586ad2defb664c9298e4e
parent5d4cfb52c51ce0ac3831034b4e0c87f2766517f5
Input: ps2-gpio - enforce GPIOs flag open drain

The PS/2 bus defines the data and clock line be open drain, therefore
for both enforce the particular GPIO flags in the driver.

Without enforcing to flag at least the clock gpio as open drain we run
into the following warning:

WARNING: CPU: 1 PID: 40 at drivers/gpio/gpiolib.c:3175 gpiochip_enable_irq+0x54/0x90

gpiochip_enable_irq() warns on a GPIO being configured as output while
serving as IRQ source without being flagged as open drain.

Signed-off-by: Danilo Krummrich <danilokrummrich@dk-develop.de>
Link: https://lore.kernel.org/r/20220215180829.63543-4-danilokrummrich@dk-develop.de
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/serio/ps2-gpio.c