]> git.baikalelectronics.ru Git - kernel.git/commit
staging: rtl8723bs: fix a potential memory leak in rtw_init_cmd_priv()
authorXiaoke Wang <xkernel.wang@foxmail.com>
Fri, 9 Sep 2022 11:27:21 +0000 (19:27 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Oct 2022 11:22:58 +0000 (13:22 +0200)
commit38fde04cf6f9fceb43852e0f9aab48f1d17cdbe1
tree5558781098dd13c179a7e5fe5473b33ec7eafa8b
parent08959d3cc7b3b35f12046ad8dd736656ec306566
staging: rtl8723bs: fix a potential memory leak in rtw_init_cmd_priv()

[ Upstream commit c6ae3f73e44b4d973300fd9828071eda1dbc313f ]

In rtw_init_cmd_priv(), if `pcmdpriv->rsp_allocated_buf` is allocated
in failure, then `pcmdpriv->cmd_allocated_buf` will be not properly
released. Besides, considering there are only two error paths and the
first one can directly return, so we do not need implicitly jump to the
`exit` tag to execute the error handler.

So this patch added `kfree(pcmdpriv->cmd_allocated_buf);` on the error
path to release the resource and simplified the return logic of
rtw_init_cmd_priv(). As there is no proper device to test with, no runtime
testing was performed.

Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
Link: https://lore.kernel.org/r/tencent_2B7931B79BA38E22205C5A09EFDF11E48805@qq.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/staging/rtl8723bs/core/rtw_cmd.c