]> git.baikalelectronics.ru Git - kernel.git/commit
tty: n_gsm: fix race condition in gsmld_write()
authorDaniel Starke <daniel.starke@siemens.com>
Fri, 1 Jul 2022 06:16:52 +0000 (08:16 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Aug 2022 09:18:02 +0000 (11:18 +0200)
commit3806e9a5ea6bb45daead198d34e2fafef3272959
tree8df36bc21ce50c54eb9dfb61685f634e9526c47e
parent7853234fd12cc0eea039fd3aee498aca6dd78fd8
tty: n_gsm: fix race condition in gsmld_write()

[ Upstream commit 5326d1492ede5e82b2e7d08db965026e57787fb4 ]

The function may be used by the user directly and also by the n_gsm
internal functions. They can lead into a race condition which results in
interleaved frames if both are writing at the same time. The receiving side
is not able to decode those interleaved frames correctly.

Add a lock around the low side tty write to avoid race conditions and frame
interleaving between user originated writes and n_gsm writes.

Fixes: 99551fa31543 ("tty: n_gsm line discipline")
Signed-off-by: Daniel Starke <daniel.starke@siemens.com>
Link: https://lore.kernel.org/r/20220701061652.39604-9-daniel.starke@siemens.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/tty/n_gsm.c