]> git.baikalelectronics.ru Git - kernel.git/commit
mfd: intel_quark_i2c_gpio: Revert "Constify static struct resources"
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 2 Mar 2021 13:56:16 +0000 (15:56 +0200)
committerLee Jones <lee.jones@linaro.org>
Tue, 23 Mar 2021 09:14:12 +0000 (09:14 +0000)
commit37e9fbc2a5c246cd733a74195633d3af577fb593
tree428158bea75f4eac3fbcf5d39b7a003809c829f8
parent219c9076286fd92026e818ab1375558e5b20649f
mfd: intel_quark_i2c_gpio: Revert "Constify static struct resources"

The structures are used as place holders, so they are modified at run-time.
Obviously they may not be constants.

  BUG: unable to handle page fault for address: d0643220
  ...
  CPU: 0 PID: 110 Comm: modprobe Not tainted 5.11.0+ #1
  Hardware name: Intel Corp. QUARK/GalileoGen2, BIOS 0x01000200 01/01/2014
  EIP: intel_quark_mfd_probe+0x93/0x1c0 [intel_quark_i2c_gpio]

This partially reverts the commit c29a71c2ef6da1dab857238448f6c3539a686fef.

While at it, add a comment to avoid similar changes in the future.

Fixes: c29a71c2ef6d ("mfd: Constify static struct resources")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Tested-by: Tong Zhang <ztong0001@gmail.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/intel_quark_i2c_gpio.c