]> git.baikalelectronics.ru Git - kernel.git/commit
random: pull add_hwgenerator_randomness() declaration into random.h
authorJason A. Donenfeld <Jason@zx2c4.com>
Sun, 13 Feb 2022 15:17:01 +0000 (16:17 +0100)
committerJason A. Donenfeld <Jason@zx2c4.com>
Mon, 21 Feb 2022 20:14:21 +0000 (21:14 +0100)
commit37e29fe5c6bea44d15bfd1c93359f64c76b868e8
tree322a78d2c472043fdbc3a1019becbe4bf4057849
parent1639883b8ba021777eb1c895ea3caa1ba03700f3
random: pull add_hwgenerator_randomness() declaration into random.h

add_hwgenerator_randomness() is a function implemented and documented
inside of random.c. It is the way that hardware RNGs push data into it.
Therefore, it should be declared in random.h. Otherwise sparse complains
with:

random.c:1137:6: warning: symbol 'add_hwgenerator_randomness' was not declared. Should it be static?

The alternative would be to include hw_random.h into random.c, but that
wouldn't really be good for anything except slowing down compile time.

Cc: Matt Mackall <mpm@selenic.com>
Cc: Theodore Ts'o <tytso@mit.edu>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Reviewed-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
drivers/char/hw_random/core.c
include/linux/hw_random.h
include/linux/random.h