]> git.baikalelectronics.ru Git - kernel.git/commit
media: v4l: ioctl: Fix memory leak in video_usercopy
authorSakari Ailus <sakari.ailus@linux.intel.com>
Sat, 19 Dec 2020 22:29:58 +0000 (23:29 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 12 Jan 2021 16:06:16 +0000 (17:06 +0100)
commit37b013d54d5812ba142340f96e28afe4cf62cadd
treeffa8ce23a4fd2f4122bcf1cbb9ec38241f4743fe
parentaba4b264416cb23a0267c6a89c567cba4786b803
media: v4l: ioctl: Fix memory leak in video_usercopy

When an IOCTL with argument size larger than 128 that also used array
arguments were handled, two memory allocations were made but alas, only
the latter one of them was released. This happened because there was only
a single local variable to hold such a temporary allocation.

Fix this by adding separate variables to hold the pointers to the
temporary allocations.

Reported-by: Arnd Bergmann <arnd@kernel.org>
Reported-by: syzbot+1115e79c8df6472c612b@syzkaller.appspotmail.com
Fixes: a3be879b4202 ("[media] v4l: Add multi-planar ioctl handling code")
Cc: stable@vger.kernel.org
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/v4l2-core/v4l2-ioctl.c