]> git.baikalelectronics.ru Git - kernel.git/commit
qlge: Fix netdev features configuration.
authorManish Chopra <manish.chopra@cavium.com>
Thu, 23 Aug 2018 20:20:52 +0000 (13:20 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 26 Aug 2018 00:37:38 +0000 (17:37 -0700)
commit377cd180ab2c9fc4a60e653192be4cf787a27d3c
tree6c84f164eff5a7c25e49e5c2dafc84e6c7a37813
parent3895679e6125c687d02f4977ddebf63771b38a45
qlge: Fix netdev features configuration.

qlge_fix_features() is not supposed to modify hardware or
driver state, rather it is supposed to only fix requested
fetures bits. Currently qlge_fix_features() also goes for
interface down and up unnecessarily if there is not even
any change in features set.

This patch changes/fixes following -

1) Move reload of interface or device re-config from
   qlge_fix_features() to qlge_set_features().
2) Reload of interface in qlge_set_features() only if
   relevant feature bit (NETIF_F_HW_VLAN_CTAG_RX) is changed.
3) Get rid of qlge_fix_features() since driver is not really
   required to fix any features bit.

Signed-off-by: Manish <manish.chopra@cavium.com>
Reviewed-by: Benjamin Poirier <bpoirier@suse.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qlge/qlge_main.c