]> git.baikalelectronics.ru Git - kernel.git/commit
drivers: base: cacheinfo: Do not populate sysfs for unknown cache types
authorJeffrey Hugo <jhugo@codeaurora.org>
Thu, 4 Oct 2018 15:20:05 +0000 (09:20 -0600)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 4 Oct 2018 21:02:17 +0000 (23:02 +0200)
commit3778458fbd1cda2b6dbee6d8d96b9286b6be0516
treea1416d6caedb84dd27abf90fa07cd34917682cbb
parent5dfa044c3a3b9125da254b1d9969551d27523c1c
drivers: base: cacheinfo: Do not populate sysfs for unknown cache types

If a cache has an unknown type because neither the hardware nor the
firmware told us, an entry in the sysfs tree will be made, but the type
file will not be present.  lscpu depends on the type file being present
for every entry, and will error out without printing system information
if lscpu cannot open the type file.

Presenting information about a cache without indicating its type is not
useful, therefore if we hit a cache with an unknown type, stop populating
sysfs so that userspace has the maximum amount of useful information.

This addresses the following lscpu error, which prevents any output.
lscpu: cannot open /sys/devices/system/cpu/cpu0/cache/index3/type: No such
file or directory

Suggested-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/base/cacheinfo.c