]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Restore correct bxt_ddi_phy_calc_lane_lat_optim_mask() calculation
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 11 Apr 2019 16:49:25 +0000 (19:49 +0300)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Mon, 15 Apr 2019 16:36:42 +0000 (09:36 -0700)
commit373198d93ff2a0088f68334509c5586306497457
treeabf75402bce41d62c9bec5b5085c2012953638a6
parent4a9ecc8fcc961bc9bfb55475e82ece9aa3360435
drm/i915: Restore correct bxt_ddi_phy_calc_lane_lat_optim_mask() calculation

We are no longer calling bxt_ddi_phy_calc_lane_lat_optim_mask() when
intel{hdmi,dp}_compute_config() succeeds, and instead only call it
when those fail. This is fallout from the bool->int
.compute_config() conversion which failed to invert the return
value check before calling bxt_ddi_phy_calc_lane_lat_optim_mask().
Let's just replace it with an early bailout so that it's harder
to miss.

This restores the correct latency optim setting calculation
(which could fix some real failures), and avoids the
MISSING_CASE() from bxt_ddi_phy_calc_lane_lat_optim_mask()
after intel{hdmi,dp}_compute_config() has failed.

Cc: Lyude Paul <lyude@redhat.com>
Fixes: d27d396b039f ("drm/i915: Pass down rc in intel_encoder->compute_config()")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109373
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190411164925.28491-1-ville.syrjala@linux.intel.com
Reviewed-by: Lyude Paul <lyude@redhat.com>
(cherry picked from commit 7a412b8f60cd57ab7dcb72ab701fde2bf81752eb)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/i915/intel_ddi.c