]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: mpt3sas: remove redundant wmb
authorSinan Kaya <okaya@codeaurora.org>
Fri, 7 Apr 2017 19:06:18 +0000 (15:06 -0400)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 24 Apr 2017 22:31:41 +0000 (18:31 -0400)
commit36ea79577bd1fa9dfe5b0a2d81072335ce2c0074
treed4d12d01d5dd3ddac23834ba2f9649ac7c6e744d
parent1a172f7b84b111598a52bb1920cc20b460b840d1
scsi: mpt3sas: remove redundant wmb

Due to relaxed ordering requirements on multiple architectures, drivers
are required to use wmb/rmb/mb combinations when they need to guarantee
observability between the memory and the HW.

The mpt3sas driver is already using wmb() for this purpose.  However, it
issues a writel following wmb(). writel() function on arm/arm64
arhictectures have an embedded wmb() call inside.

This results in unnecessary performance loss and code duplication.

writel already guarantees ordering for both cpu and bus. we don't need
additional wmb()

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
Acked-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Reviewed-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpt3sas/mpt3sas_base.c