]> git.baikalelectronics.ru Git - kernel.git/commit
lib/test_string.c: avoid masking memset16/32/64 failures
authorPeter Rosin <peda@axentia.se>
Tue, 16 Jul 2019 23:27:18 +0000 (16:27 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 17 Jul 2019 02:23:22 +0000 (19:23 -0700)
commit36d9733574844545185920a052be812e95fac48b
tree8479d93b260826a01e85a9669e7ec88fa7b5fb36
parente1efaaae16792518871f72287f968ae20c5a32e7
lib/test_string.c: avoid masking memset16/32/64 failures

If a memsetXX implementation is completely broken and fails in the first
iteration, when i, j, and k are all zero, the failure is masked as zero
is returned.  Failing in the first iteration is perhaps the most likely
failure, so this makes the tests pretty much useless.  Avoid the
situation by always setting a random unused bit in the result on
failure.

Link: http://lkml.kernel.org/r/20190506124634.6807-3-peda@axentia.se
Fixes: 92ed495f8403 ("lib/string.c: add testcases for memset16/32/64")
Signed-off-by: Peter Rosin <peda@axentia.se>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
lib/test_string.c