]> git.baikalelectronics.ru Git - kernel.git/commit
sunrpc/cache: drop reference when sunrpc_cache_pipe_upcall() detects a race
authorNeilBrown <neilb@suse.com>
Fri, 4 Mar 2016 06:20:13 +0000 (17:20 +1100)
committerJ. Bruce Fields <bfields@redhat.com>
Thu, 17 Mar 2016 18:57:15 +0000 (14:57 -0400)
commit368234bd0eca038168887769393b9bc14f4e4069
treedb1e6dad9377a523e58bcb685bde47b1ecec7884
parentf5db2dbcfde40031bce913c9856463a378788a23
sunrpc/cache: drop reference when sunrpc_cache_pipe_upcall() detects a race

sunrpc_cache_pipe_upcall() can detect a race if CACHE_PENDING is no longer
set.  In this case it aborts the queuing of the upcall.
However it has already taken a new counted reference on "h" and
doesn't "put" it, even though it frees the data structure holding the reference.

So let's delay the "cache_get" until we know we need it.

Fixes: eb8d85b7700e ("sunrpc/cache: remove races with queuing an upcall.")
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
net/sunrpc/cache.c