]> git.baikalelectronics.ru Git - kernel.git/commit
can: isotp: isotp_rcv_cf(): enable RX timeout handling in listen-only mode
authorOliver Hartkopp <socketcan@hartkopp.net>
Mon, 19 Oct 2020 12:02:29 +0000 (14:02 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Tue, 3 Nov 2020 21:30:32 +0000 (22:30 +0100)
commit35eb11eb3644880ad7c8092888b55f53f16ad796
tree7c0108df7bbe6bd293284dad010971440c5103f9
parentc9b125aee7cacec1677ae2dd50d953a1f4247d3d
can: isotp: isotp_rcv_cf(): enable RX timeout handling in listen-only mode

As reported by Thomas Wagner:

    https://github.com/hartkopp/can-isotp/issues/34

the timeout handling for data frames is not enabled when the isotp socket is
used in listen-only mode (sockopt CAN_ISOTP_LISTEN_MODE). This mode is enabled
by the isotpsniffer application which therefore became inconsistend with the
strict rx timeout rules when running the isotp protocol in the operational
mode.

This patch fixes this inconsistency by moving the return condition for the
listen-only mode behind the timeout handling code.

Reported-by: Thomas Wagner <thwa1@web.de>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Fixes: 3f9425168a78 ("can: add ISO 15765-2:2016 transport protocol")
Link: https://github.com/hartkopp/can-isotp/issues/34
Link: https://lore.kernel.org/r/20201019120229.89326-1-socketcan@hartkopp.net
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
net/can/isotp.c