]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: target: Remove XDWRITEREAD emulated support
authorMike Christie <michael.christie@oracle.com>
Tue, 26 Jul 2022 23:53:39 +0000 (18:53 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 27 Jul 2022 02:40:31 +0000 (22:40 -0400)
commit35e87d898859d4aafd2cc1e8a9fe8d407205a6c9
tree11868566bfc8b58104caa09847cac87c10eb1809
parent6974d2bbfd9435556004d145cc1929451af84a57
scsi: target: Remove XDWRITEREAD emulated support

This patch removes XDWRITEREAD support because it never fully worked when
it was added in the initial LIO merge and it's been fully broken since 2013
from commit 5cf98882d796 ("target: Add compare_and_write_post() completion
callback fall through").

The two issues above are:

1. XDWRITEREAD support was just never completed when LIO was merged. We
never did the DISABLE WRITE check and so we never write data out.

2. Since the commit above, we never complete the command. After we do the
XOR, we return from xdreadwrite_callback and that's it. We never send a
response for the command, so the command will always time out and fail.

Since this has been fully broken for almost nine years this patch just
removes emulated support.

Link: https://lore.kernel.org/r/20220726235339.14551-1-michael.christie@oracle.com
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/target_core_sbc.c