]> git.baikalelectronics.ru Git - kernel.git/commit
dmaengine: dmatest: Fix iteration non-stop logic
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 24 Apr 2020 16:11:42 +0000 (19:11 +0300)
committerVinod Koul <vkoul@kernel.org>
Mon, 27 Apr 2020 16:15:35 +0000 (21:45 +0530)
commit3597eed1c0188418d754e66c1eef0981c9a8b180
treee1f60e51ce9bbf71c8da8f88cb2fd256191da36d
parent6024924250ff30688ba97953e74e28a6f7fc34b8
dmaengine: dmatest: Fix iteration non-stop logic

Under some circumstances, i.e. when test is still running and about to
time out and user runs, for example,

grep -H . /sys/module/dmatest/parameters/*

the iterations parameter is not respected and test is going on and on until
user gives

echo 0 > /sys/module/dmatest/parameters/run

This is not what expected.

The history of this bug is interesting. I though that the commit
  44683463bcb1 ("dmatest: add a 'wait' parameter")
is a culprit, but looking closer to the code I think it simple revealed the
broken logic from the day one, i.e. in the commit
  8d16729adb9d ("dmaengine: dmatest: add a maximum number of test iterations")
which adds iterations parameter.

So, to the point, the conditional of checking the thread to be stopped being
first part of conjunction logic prevents to check iterations. Thus, we have to
always check both conditions to be able to stop after given iterations.

Since it wasn't visible before second commit appeared, I add a respective
Fixes tag.

Fixes: 44683463bcb1 ("dmatest: add a 'wait' parameter")
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20200424161147.16895-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/dmatest.c