]> git.baikalelectronics.ru Git - kernel.git/commit
ACPI: APD: Check for NULL pointer after calling devm_ioremap()
authorJiasheng Jiang <jiasheng@iscas.ac.cn>
Fri, 7 Jan 2022 03:35:16 +0000 (11:35 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 11 Jan 2022 15:35:41 +0000 (16:35 +0100)
commit3526cafd28aeec8e00749ef547c4b0935ed506bf
treebcc7205e53999ec0890217c3af61ecc87cda71bb
parent62adf648ce3c8ed27ce9b2f9227e5671c2947ba6
ACPI: APD: Check for NULL pointer after calling devm_ioremap()

Because devres_alloc() may fail, devm_ioremap() may return NULL.

Then, 'clk_data->base' will be assigned to clkdev->data->base in
platform_device_register_data().

The PTR_ERR_OR_ZERO() check on clk_data does not cover 'base', so
it is better to add an explicit check against NULL after updating
it.

Fixes: 691f7167f31f ("ACPI: APD: Add AMD misc clock handler support")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
[ rjw: Changelog rewrite ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/acpi_apd.c