]> git.baikalelectronics.ru Git - kernel.git/commit
regulator: da9121: Potential Oops in da9121_assign_chip_model()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 7 Dec 2020 17:55:44 +0000 (20:55 +0300)
committerMark Brown <broonie@kernel.org>
Tue, 8 Dec 2020 14:21:13 +0000 (14:21 +0000)
commit35248172d24876da4672238111092c37338ff840
tree6060f6b51705f9fbf920b28c83df532a8db0e395
parentde0c083b78d15aca8660d8c87e14c76e5fe1c2d5
regulator: da9121: Potential Oops in da9121_assign_chip_model()

There is a missing "return ret;" on this error path so we call
"da9121_check_device_type(i2c, chip);" which will end up dereferencing
"chip->regmap" and lead to an Oops.

Fixes: 0ac9b60e42ce ("regulator: da9121: Add device variant regmaps")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Adam Ward <Adam.Ward.opensource@diasemi.com>
Link: https://lore.kernel.org/r/X85soGKnWAjPUA7a@mwanda
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/da9121-regulator.c