]> git.baikalelectronics.ru Git - kernel.git/commit
davinci: gpio irq enable tweaks
authorDavid Brownell <dbrownell@users.sourceforge.net>
Mon, 4 May 2009 20:14:27 +0000 (13:14 -0700)
committerKevin Hilman <khilman@deeprootsystems.com>
Tue, 26 May 2009 14:17:54 +0000 (07:17 -0700)
commit351e8295eb176bbdaa12b76545c03d4c5a371928
tree3ac065f49b9f20d0e759b829824caf7553358e32
parentf8d87df3763c6b8454a30ddd50ef6ce9f0982182
davinci: gpio irq enable tweaks

Fix two IRQ triggering bugs affecting GPIO IRQs:

 - Make sure enabling with IRQ_TYPE_NONE ("default, unspecified")
   isn't a NOP ... default to both edges, at least one must work.

 - As noted by Kevin Hilman, setting the irq trigger type for a
   banked gpio interrupt shouldn't enable irqs that are disabled.

Since GPIO IRQs haven't been used much yet, it's not clear these
bugs could have affected anything.  The few current users don't
seem to have been obviously suffering from these issues.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
arch/arm/mach-davinci/gpio.c