]> git.baikalelectronics.ru Git - kernel.git/commit
bpf: don't mark FP reg as uninit
authorAlexei Starovoitov <ast@fb.com>
Fri, 1 Dec 2017 05:31:37 +0000 (21:31 -0800)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 1 Dec 2017 10:25:10 +0000 (11:25 +0100)
commit350e5d91d238668c69d0f45b4a586efc56c56034
treebef3d86b652404095dff4416aa072332e774e9db
parentede191704c01b06c028e07e212087f7d4a95986b
bpf: don't mark FP reg as uninit

when verifier hits an internal bug don't mark register R10==FP as uninit,
since it's read only register and it's not technically correct to let
verifier run further, since it may assume that R10 has valid auxiliary state.

While developing subsequent patches this issue was discovered,
though the code eventually changed that aux reg state doesn't have
pointers any more it is still safer to avoid clearing readonly register.

Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
kernel/bpf/verifier.c