]> git.baikalelectronics.ru Git - kernel.git/commit
can: pch_can: pch_can_error(): initialize errc before using it
authorVincent Mailhol <mailhol.vincent@wanadoo.fr>
Thu, 21 Jul 2022 16:00:32 +0000 (01:00 +0900)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Thu, 21 Jul 2022 16:19:01 +0000 (18:19 +0200)
commit34fb99374469e0509a508a0070ca013534fedd06
treef2fa185dff00c39ddf7ffa0b7db9aee02ea9a669
parent9c66173f51950a5138951835f69fb0aae9924a96
can: pch_can: pch_can_error(): initialize errc before using it

After commit cafa6337968f, the variable errc is accessed before being
initialized, c.f. below W=2 warning:

| In function 'pch_can_error',
|     inlined from 'pch_can_poll' at drivers/net/can/pch_can.c:739:4:
| drivers/net/can/pch_can.c:501:29: warning: 'errc' may be used uninitialized [-Wmaybe-uninitialized]
|   501 |                 cf->data[6] = errc & PCH_TEC;
|       |                             ^
| drivers/net/can/pch_can.c: In function 'pch_can_poll':
| drivers/net/can/pch_can.c:484:13: note: 'errc' was declared here
|   484 |         u32 errc, lec;
|       |             ^~~~

Moving errc initialization up solves this issue.

Fixes: cafa6337968f ("can: pch_can: do not report txerr and rxerr during bus-off")
Reported-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/all/20220721160032.9348-1-mailhol.vincent@wanadoo.fr
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/pch_can.c