]> git.baikalelectronics.ru Git - kernel.git/commit
staging: rtl8723bs: avoid null pointer dereference on pmlmepriv
authorColin Ian King <colin.king@canonical.com>
Wed, 20 Sep 2017 17:34:18 +0000 (18:34 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 22 Sep 2017 09:00:58 +0000 (11:00 +0200)
commit34949d22afeeea2017f32047603b48da46c0ab82
treee6c67c5fd129ce9f7ae7d1f28ecf6dec2b854a3d
parent500ac98483310baee1ac6a0a1944ecff2d03ba71
staging: rtl8723bs: avoid null pointer dereference on pmlmepriv

There is a check to see if pmlmepriv is null before vfree'ing
pmlmepriv->free_bss_buf hence implying pmlmepriv could potenially be
null. However, a previous call to rtw_free_mlme_priv_ie_data
can also dereference pmlmepriv, so move this call so that it is only
called if pmlmepriv non-null.

Detected by CoverityScan, CID#1077739 ("Dereference before null check")

Fixes: 84ed90a855bc ("staging: Add rtl8723bs sdio wifi driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_mlme.c