]> git.baikalelectronics.ru Git - kernel.git/commit
net/rose: Fix to not accept on connected socket
authorHyunwoo Kim <v4bel@theori.io>
Wed, 25 Jan 2023 10:59:44 +0000 (02:59 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Feb 2023 11:50:34 +0000 (12:50 +0100)
commit347ab7b7b4941f4cbbaf2b1e822be0535b0ba22d
tree8711d3d6b6b5a9d9b86bf524de8688559de4816a
parent1a53c0643ce58b52581a60692381b13a7c8c40c6
net/rose: Fix to not accept on connected socket

[ Upstream commit 14caefcf9837a2be765a566005ad82cd0d2a429f ]

If you call listen() and accept() on an already connect()ed
rose socket, accept() can successfully connect.
This is because when the peer socket sends data to sendmsg,
the skb with its own sk stored in the connected socket's
sk->sk_receive_queue is connected, and rose_accept() dequeues
the skb waiting in the sk->sk_receive_queue.

This creates a child socket with the sk of the parent
rose socket, which can cause confusion.

Fix rose_listen() to return -EINVAL if the socket has
already been successfully connected, and add lock_sock
to prevent this issue.

Signed-off-by: Hyunwoo Kim <v4bel@theori.io>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Link: https://lore.kernel.org/r/20230125105944.GA133314@ubuntu
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/rose/af_rose.c