]> git.baikalelectronics.ru Git - kernel.git/commit
x86: Don't clear olpc_ofw_header when sentinel is detected
authorDaniel Drake <dsd@laptop.org>
Fri, 9 Aug 2013 22:14:20 +0000 (18:14 -0400)
committerH. Peter Anvin <hpa@linux.intel.com>
Fri, 9 Aug 2013 22:29:48 +0000 (15:29 -0700)
commit33e5c05edf55fa1562910ceac50a8b634b86fde2
treeaa463bff9b5f8c5933f6b7c82c06b39243dbbf3c
parentbca0e4e1b7ed9b6af497e885eb8c84d53585865d
x86: Don't clear olpc_ofw_header when sentinel is detected

OpenFirmware wasn't quite following the protocol described in boot.txt
and the kernel has detected this through use of the sentinel value
in boot_params. OFW does zero out almost all of the stuff that it should
do, but not the sentinel.

This causes the kernel to clear olpc_ofw_header, which breaks x86 OLPC
support.

OpenFirmware has now been fixed. However, it would be nice if we could
maintain Linux compatibility with old firmware versions. To do that, we just
have to avoid zeroing out olpc_ofw_header.

OFW does not write to any other parts of the header that are being zapped
by the sentinel-detection code, and all users of olpc_ofw_header are
somewhat protected through checking for the OLPC_OFW_SIG magic value
before using it. So this should not cause any problems for anyone.

Signed-off-by: Daniel Drake <dsd@laptop.org>
Link: http://lkml.kernel.org/r/20130809221420.618E6FAB03@dev.laptop.org
Acked-by: Yinghai Lu <yinghai@kernel.org>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Cc: <stable@vger.kernel.org> # v3.9+
arch/x86/include/asm/bootparam_utils.h